From: Keir Fraser <keir.fraser@citrix.com>
Date: Thu, 27 May 2010 07:26:52 +0000 (+0100)
Subject: libxl: Do not provide arbitrary string as format specifier to printf.
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~12078
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https:/%22bookmarks://%22/%22http:/www.example.com/cgi/%22https:/%22bookmarks:/%22?a=commitdiff_plain;h=56022b307133da3b9efc728ecbe37fa6b883c1b9;p=xen.git

libxl: Do not provide arbitrary string as format specifier to printf.

Original patch from Dulloor <dulloor@gmail.com>
Signed-off-by: Keir Fraser <keir.fraser@citrix.com>
---

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 0fe6be9116..85c6e1b129 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -3267,13 +3267,8 @@ int main_dmesg(int argc, char **argv)
     if (!cr)
         goto finish;
 
-    while (1) {
-        ret = libxl_xen_console_read_line(&ctx, cr, &line);
-        if (ret > 0)
-            printf(line);
-        else
-            break;
-    }
+    while ((ret = libxl_xen_console_read_line(&ctx, cr, &line)) > 0)
+        printf("%s", line);
 
 finish:
     libxl_xen_console_read_finish(&ctx, cr);